Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tcl getuser command submits botaddr ports in wrong order #459
Documentation implies (doesn't actually state) the order for changing a botaddr with setuser is address, telnet port, bot port:
But it appears it reverses user and bot ports when you submit it
Recommend adjusting documentation for 1.8.3, and discussing the merits of "fixing" this in 2.0, as it would be a non-backward compatible change to the API. (Reminder to self, if we do that, please submit a new issue for that and tag it 2.0 before we close this one).
For bonus consideration points,
sets only the bot port (not the user port). I'm ok with modifying docs, but just want to point out how non-standard this behavior is when compared to the +bot syntax, where specifying a single port sets bot bot and user.
I'm on a standardization kick this month, it seems
Working on this now - bot foo is added like this:
Doing a chaddr with only one port argument changes both bot and user ports:
Using the Tcl command with only one port argument changes only the bot listening port:
To standardize this between chaddr and the associated Tcl setuser command, I think it makes sense to implement this the way that chaddr does, where one argument changes both values, and two arguments allows you to set them individually. Comments/Improvements?
Ok. Part 2- can anyone come up with a reason to say this changing this is not backwards compatible (and thus belongs in 2.0)? While technically it changes functionality that could break existing scripts, every use case I can think of doesn't seem plausible that a script writer would use it this way for, but that's not my thing. On the other hand, I'm not comfortable calling this a 'bug', as it appears to be intentional coding on both commands, just not synched.
I really want to do this now, but I can't get away from believing this is a 2.0 thing. Can someone convince me otherwise?
@maimizuno likely has some thoughts on this