New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on self-lookup fail #468

Open
thommey opened this Issue Oct 7, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@thommey
Member

thommey commented Oct 7, 2017

The ctcp module (CHAT) loops through all telnet ports to find an eligible one to send the DCC CHAT request from.
The condition for it to be valid relies on being able to find an associated IP to send (and making sure it's a listenport, a user listen port, etc.).
The IP determination logic goes (amongst others) through listen-addr and nat-ip.
If no suitable IP can be determined (0.0.0.0 is not suitable), the port is skipped, and if no valid ports are found, leads to the error message "no telnet port", regardless of whether the real issue was the IP lookup.
This should be improved to tell the user what's really going on, and suggest setting nat-ip (or listen-addr).

Found by: acidtech, SergioR

@michaelortmann

This comment has been minimized.

Show comment
Hide comment
@michaelortmann

michaelortmann Sep 13, 2018

Contributor

Can you give a small example / how to repeat / how to trigger the bug ?

Contributor

michaelortmann commented Sep 13, 2018

Can you give a small example / how to repeat / how to trigger the bug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment