Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add language-path option to config #474
I have an eggdrop installed by a package manager. Without being able to set the help-path it requires that I either make a symlink to the help dir in my bots working directory to the system provided help path, or patch the headers with the system help path. See https://github.com/ismell/pkgsrc/blob/6aceea71d3e95aa947ba50282e8f0e60adb2b238/chat/eggdrop/patches/patch-langdir and https://github.com/ismell/pkgsrc/blob/6aceea71d3e95aa947ba50282e8f0e60adb2b238/chat/eggdrop/Makefile#L18
i was also thinking, whether the netbsd packaging may be wrong here, but meanwhile i see other packagings are also patching it somehow, for example arch linux aur:
so, currently eggdrop is meant to be installed into a single user directory like /home/user/eggdrop or single systemwide directory like /opt/eggdrop but its not friendly to package managers who want to install eggdrop into "normal" system directories to fit into the existing file system structure with /usr/share and the like.
so this issue is about package manager friendliness, and here is a real bug to fix.
there is more: in language.c there is:
btw: we have addlang config option. we should not need an alternative environment var EGG_LANG.
my first proposal was:
but then i saw, this is NOT possible.
i looked at the package install in netbsd and arch linux aur
so now proposal is, to set the language path, like you would set library path,
i think its time, to not install eggdrop to users home by default,
pushed a commit
Aug 27, 2018
irc discussion result:
change ./configure --prefix to install all parts off eggdrop into 'expected' directories, like prefix/bin and prefix/lib. will ease system wide installation, as long as you remember, you have to specify --prefix /usr explicitely because if you dont, then eggdrop will install in a backward compatible manner into the users home.
we can also change that backward compatible manner with eggdrop 2.0, i hope.
the new --prefix behaviour is fine even for multiple eggdrops per user, because we already have the -c option to start each eggdrop with.
the new --prefix behavior will also bring us better support for language directory, because then it can be specified at configure time. we could even add a --languagedir option to configure.
the test could preferably be done with package managers like dbrewery, because i see freebsd eggdrop ports are kind of... zombies... 1.6.21_1 and 184.108.40.20641008_2.
see also hier(7) to see which files should be put in which directories.
don't worry about telling the user to set LD_LIBRARY_PATH, if eggdrop is installed with ./configure/make... it will know where to find stuff and thus it will be able to load modules/etc there and could set whatever ENV it needs itself.
we also want this prefix change, because of #709