Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
listen +port prevents bot connections #754
Placeholder to troubleshoot this issue from discussion in #552 .
A bot listening with +port isn't sending a STARTTLS.
and the connection fails.
Are you sure, the listener is the problem or the right place to fix? In case #552 the caller was not doing STARTTLS, if it did, it would probably succeed. There is already theory of a patch in #552, and a small example demostrating that fix could work. That fix opened a new problem that must be fixed, a fallback from STARTTLS to PLAIN if the connection failed. There is also a theory of a patch in #552 for this addional problem.
You can find the fix and the rest of the story in #755.
This was referenced
Nov 4, 2018
Its interesting that in some cases the calling bot does start the handshake and in other cases the called bot sends starttls. Maybe there are cases that both is happening. Something doesnt look right here. I realy wasnt expecting a called bot to send starttls if i didnt initialize it. This could lead to bigger problems like in #552 where we want to force into non ssl link. We dont want and dont need the called bot to send unwanted starttls!
Part of the problem here is also that we speak of 2 thinks and think in different ways, when we take into account the called bot could send starttls. i really didn't think of this possibility until i was forced to when i had to look deeper into #552.