New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad code style: sizeof info lost with "extern char foo[]" #757

Open
michaelortmann opened this Issue Nov 7, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@michaelortmann
Member

michaelortmann commented Nov 7, 2018

Hei hei,

Eggdrop is using extern char foo[] to use arrays across c files.
So sizeof info is lost, sizeof foo is not useful anymore.
To avoid workarounds and use sizeof in a clean and secure ways across the code, i propose to change all those externs, and put all those char arrays into header files.
This is kind of restructuring / of a bigger change.
But we don't need individual header files per c file, we can put them all into one.
eggdrop.h? main.h? a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment