Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASL To-Do's #832

Open
vanosg opened this issue Jul 26, 2019 · 1 comment

Comments

@vanosg
Copy link
Member

commented Jul 26, 2019

This is a placeholder issue to track SASL-related implementation items.

  • Handle timeouts during connect
  • Handle failed SASL auth - connect anyway, or jump to next server?
  • Error check key files before authentication
  • Deconflict with pre-init binds
  • Handle bots without openssl installed
  • #688 (comment) - grawity proposed replacing sasl state processing with real state keeping.
  • Compat/Fallback for resolv.h base64 encode b64_ntop() and base64 decode b64_pton()
  • Implement scram authentication
  • Handle 908 messages
@michaelortmann

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

  • Example, were we need Compat/Fallback base64 is musl (openwrt):
gcc -fPIC -g -O2 -pipe -Wall -I. -I../../.. -I../../.. -I../../../src/mod  -DHAVE_CONFIG_H -I/home/michael/opt/tcl-8.6.8/include -g3 -DDEBUG -DDEBUG_ASSERT -DDEBUG_MEM -DDEBUG_DNS  -DMAKING_MODS -c .././server.mod/server.c && mv -f server.o ../
In file included from .././server.mod/server.c:132:0:
.././server.mod/servmsg.c: In function 'tryauthenticate':
.././server.mod/servmsg.c:1178:11: warning: implicit declaration of function 'b64_ntop' [-Wimplicit-function-declaration]
       if (b64_ntop((unsigned char *) src, s - src, (char *) dst, sizeof dst) == -1) {
           ^
  • scram authentication would need pbkdf2, which we would also need for new password method replacing blowfish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.