Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #944

Open
michaelortmann opened this issue Mar 25, 2020 · 0 comments
Open

License #944

michaelortmann opened this issue Mar 25, 2020 · 0 comments

Comments

@michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Mar 25, 2020

Commit c64e7a7 updated the License, which was good.

But most of eggdrops source files still have an old header.

For example the postal address changed:

$ grep -R 02110-1301 *|wc -l
5
$ grep -R 02111-1307 *|wc -l
144

I not only suppose we mass data change the header, but we also change the header boilerplate to SPDX, see:

https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf

and

https://spdx.org/licenses/

The linux kernel uses SPDX, so it should be fine for eggdrop also:

https://github.com/torvalds/linux/blob/master/arch/x86/boot/a20.c

SPDX for eggdrop should also be GPL-2.0-only (And i dont want to see anybody complain about the "only"!)

So, in the end, i suppose we replace every license header in eggdrop source files with:
/* SPDX-License-Identifier: GPL-2.0-only */

see my following example in pbkdf2.c:

https://github.com/eggheads/eggdrop/blob/0cfea912a9650c8876a981edc8d25dcaae8fcecf/src/mod/pbkdf2.mod/pbkdf2.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.