New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add egg2 vs egg1 #14

Merged
merged 6 commits into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@dead-horse
Member

dead-horse commented Nov 15, 2017

No description provided.

dead-horse added some commits Nov 15, 2017

@dead-horse dead-horse changed the title from [WIP] feat: add egg2 vs egg1 to feat: add egg2 vs egg1 Nov 16, 2017

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse
Member

dead-horse commented Nov 16, 2017

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Nov 16, 2017

Member

LGTM!

Member

fengmk2 commented Nov 16, 2017

LGTM!

@popomore popomore referenced this pull request Nov 16, 2017

Closed

V2 #1564

26 of 29 tasks complete
@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse
Member

dead-horse commented Nov 16, 2017

image

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2
Member

fengmk2 commented Nov 16, 2017

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Nov 16, 2017

Member

randomBytes 也改改,使用一个简单的

Member

fengmk2 commented Nov 16, 2017

randomBytes 也改改,使用一个简单的

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 16, 2017

Member

csrf 由于正常访问不会一直设置 cookie,所以先在压测时关掉了,关掉后再测试更新一下结果

Member

dead-horse commented Nov 16, 2017

csrf 由于正常访问不会一直设置 cookie,所以先在压测时关掉了,关掉后再测试更新一下结果

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 16, 2017

Member

csrf 关闭后性能和 koa 的差距已经很近了

Member

dead-horse commented Nov 16, 2017

csrf 关闭后性能和 koa 的差距已经很近了

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 16, 2017

Member

image

egg 还有 meta 这个热点,其他的都是 http / koa / koa-compose 中的

Member

dead-horse commented Nov 16, 2017

image

egg 还有 meta 这个热点,其他的都是 http / koa / koa-compose 中的

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Nov 17, 2017

Member

meta 和 createContext 的热点都是由 Date.now() 带来的,6% 左右的性能消耗。

Member

dead-horse commented Nov 17, 2017

meta 和 createContext 的热点都是由 Date.now() 带来的,6% 左右的性能消耗。

f
@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse
Member

dead-horse commented Nov 17, 2017

image

f

@dead-horse dead-horse merged commit a58b50e into master Nov 17, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Node Security No known vulnerabilities found
Details
security/snyk No new issues
Details

@dead-horse dead-horse deleted the egg2-vs-egg1 branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment