New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use graceful-process to refactor app and agent worker #30

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@fengmk2
Copy link
Member

fengmk2 commented Jun 12, 2017

see #27

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #30 into master will increase coverage by 2.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   94.65%   96.83%   +2.17%     
==========================================
  Files           7        7              
  Lines         337      316      -21     
==========================================
- Hits          319      306      -13     
+ Misses         18       10       -8
Impacted Files Coverage Δ
lib/app_worker.js 96.77% <100%> (+12.68%) ⬆️
lib/agent_worker.js 100% <100%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc8949...2199a17. Read the comment docs.

@fengmk2

This comment has been minimized.

Copy link
Member

fengmk2 commented Jun 12, 2017

果然删除代码是最好的代码覆盖率提升方法

@fengmk2 fengmk2 merged commit 5f322c1 into master Jun 12, 2017

5 checks passed

codecov/patch 100% of diff hit (target 94.65%)
Details
codecov/project 96.83% (+2.17%) compared to ebc8949
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details

@fengmk2 fengmk2 deleted the use-graceful-process branch Jun 12, 2017

@fengmk2

This comment has been minimized.

Copy link
Member

fengmk2 commented Jun 12, 2017

1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment