Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set window title under win32 platform #63

Closed
wants to merge 9 commits into from

Conversation

@waitingsong
Copy link
Contributor

commented Mar 31, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
@atian25 atian25 closed this Mar 31, 2018
@atian25

This comment has been minimized.

Copy link
Member

commented Mar 31, 2018

fell free to reopen if any other good idea.

@waitingsong

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2018

用 process.title 设置windows窗口标题,然后用 tasklist /FI 以title/baseDir去匹配就可以解决window平台查找pid的问题了。 我这儿已经测试成功了。

你这么急着关嘛呢……

@atian25

This comment has been minimized.

Copy link
Member

commented Mar 31, 2018

我以为是独立一个 egg-scripts-win 去做了。
可以 reopen

@atian25 atian25 reopened this Mar 31, 2018
@codecov

This comment has been minimized.

Copy link

commented Mar 31, 2018

Codecov Report

Merging #63 into master will decrease coverage by 0.41%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   98.32%   97.91%   -0.42%     
==========================================
  Files           7        8       +1     
  Lines         419      431      +12     
==========================================
+ Hits          412      422      +10     
- Misses          7        9       +2
Impacted Files Coverage Δ
lib/agent_worker.js 100% <100%> (ø) ⬆️
lib/app_worker.js 96.22% <100%> (+0.14%) ⬆️
lib/utils/win.js 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af5ec8...baa4cf5. Read the comment docs.

waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request Apr 2, 2018
need egg-cluster patch: eggjs/egg-cluster#63
@waitingsong waitingsong referenced this pull request Apr 2, 2018
2 of 4 tasks complete
@waitingsong

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2018

npm stop with win32 support with this PR
eggjs/egg-scripts#20

waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request Apr 3, 2018
need with egg-cluster patch: eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request Apr 3, 2018
need with egg-cluster patch: eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request Apr 5, 2018
need with egg-cluster patch : eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request May 3, 2018
need egg-cluster patch: eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request May 3, 2018
need with egg-cluster patch: eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request May 3, 2018
need with egg-cluster patch: eggjs/egg-cluster#63
waitingsong added a commit to waitingsong/egg-scripts that referenced this pull request May 3, 2018
need with egg-cluster patch : eggjs/egg-cluster#63
waitingsong added 9 commits Mar 31, 2018
@waitingsong waitingsong force-pushed the waitingsong:win-title branch from 09f6fc1 to baa4cf5 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.