New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range support #13

Merged
merged 3 commits into from Jan 10, 2018

Conversation

Projects
None yet
5 participants
@helloyou2012
Contributor

helloyou2012 commented Jan 9, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

None

Description of change

Add range support and fix koajs/static-cache#1

@helloyou2012

This comment has been minimized.

Show comment
Hide comment
@helloyou2012
Contributor

helloyou2012 commented Jan 9, 2018

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Jan 9, 2018

Member

please add a test case for this feature.

Member

dead-horse commented Jan 9, 2018

please add a test case for this feature.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 9, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   96.96%   97.05%   +0.08%     
==========================================
  Files           3        3              
  Lines          33       34       +1     
==========================================
+ Hits           32       33       +1     
  Misses          1        1
Impacted Files Coverage Δ
app/middleware/static.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a56c1...6cfe97b. Read the comment docs.

codecov-io commented Jan 9, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   96.96%   97.05%   +0.08%     
==========================================
  Files           3        3              
  Lines          33       34       +1     
==========================================
+ Hits           32       33       +1     
  Misses          1        1
Impacted Files Coverage Δ
app/middleware/static.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a56c1...6cfe97b. Read the comment docs.

@helloyou2012

This comment has been minimized.

Show comment
Hide comment
@helloyou2012

helloyou2012 Jan 9, 2018

Contributor

@dead-horse test case is added, plz check.

Contributor

helloyou2012 commented Jan 9, 2018

@dead-horse test case is added, plz check.

@atian25 atian25 changed the title from Add range support to feat: add range support Jan 10, 2018

@dead-horse dead-horse merged commit cd35dea into eggjs:master Jan 10, 2018

6 checks passed

Node Security No known vulnerabilities found
Details
codecov/patch 100% of diff hit (target 96.96%)
Details
codecov/project 97.05% (+0.08%) compared to 93a56c1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Jan 10, 2018

Member

2.1.0

Member

dead-horse commented Jan 10, 2018

2.1.0

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Jan 10, 2018

Member

koajs/koa-range#12 暂时还不能 pick 到 egg@1

Member

dead-horse commented Jan 10, 2018

koajs/koa-range#12 暂时还不能 pick 到 egg@1

dead-horse added a commit that referenced this pull request Jan 10, 2018

@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse

dead-horse Jan 10, 2018

Member

已 pick 回 egg-static@1.5.0

Member

dead-horse commented Jan 10, 2018

已 pick 回 egg-static@1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment