From 36e098953df78a7417fabbc5511f25da85df874f Mon Sep 17 00:00:00 2001 From: "William.Tung" Date: Wed, 31 May 2023 18:58:38 +0800 Subject: [PATCH] test: fix the unstable for windows (#5195) After investigation for a while for windows, it seems we should delay for about 1 sec before the "assert" can find the actual error logged into the file. --- test/lib/core/logger.test.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/test/lib/core/logger.test.js b/test/lib/core/logger.test.js index 770027fe86..e6229035c6 100644 --- a/test/lib/core/logger.test.js +++ b/test/lib/core/logger.test.js @@ -160,7 +160,7 @@ describe('test/lib/core/logger.test.js', () => { mm.env('local'); app = utils.cluster('apps/logger'); app - // .debug() + // .debug() .coverage(false) .expect('stdout', /agent info/) .expect('stdout', /app info/) @@ -171,20 +171,16 @@ describe('test/lib/core/logger.test.js', () => { }); it('agent and app error should output to common-error.log', done => { - // unstable on Windows, skip it - // https://github.com/eggjs/egg/runs/7977866117?check_suite_focus=true - if (process.platform === 'win32') { - return done(); - } const baseDir = utils.getFilepath('apps/logger'); mm.env('default'); mm(process.env, 'EGG_LOG', 'none'); mm(process.env, 'EGG_HOME', baseDir); app = utils.cluster('apps/logger'); app - // .debug() + // .debug() .coverage(false) - .end(err => { + .end(async err => { + await utils.sleep(1000); assert(!err); const content = fs.readFileSync(path.join(baseDir, 'logs/logger/common-error.log'), 'utf8'); assert(content.includes('nodejs.Error: agent error'));