Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[Wikimedia:Citationhunt-leaderboard description/ko]] i18n issue #104

Closed
revi opened this issue Apr 10, 2018 · 3 comments
Closed

[[Wikimedia:Citationhunt-leaderboard description/ko]] i18n issue #104

revi opened this issue Apr 10, 2018 · 3 comments

Comments

@revi
Copy link

revi commented Apr 10, 2018

The original texts reads...

These are users that fixed the most snippets through %s in the past %s days. Well done!

Is first %s and second %s differentiated via the order of appearance? (So, first %s always mean "snippets ~" and second %s always mean "%s days"?) If I would do translation without the text feel like a translation, I need to make second %s to come first.


@eggpi
Copy link
Owner

eggpi commented Apr 10, 2018

Hi @revi! The first %s gets replaced with the name of the tool ("Citation Hunt" by default, but some languages like to translated it using the tooltitle string), and the second %s is the number of days.

Given that, do you still need to invert the order? If so, it shouldn't be too hard to make them unordered. I'm actually a little surprised this hasn't come up before with other languages. Just let me know!

@revi
Copy link
Author

revi commented Apr 11, 2018

That now makes sense. While it would be great if it was unordered, I think I managed to make it natural while preserving the order.

Thanks!

@revi revi closed this as completed Apr 11, 2018
@eggpi
Copy link
Owner

eggpi commented Apr 11, 2018

No problem, thank you for translating and for bringing this up!

By the way, to actually add a new language to Citation Hunt, we'll need a little more information about it (see our Meta page, or issue #96 as an example).

If you have that information, please file an issue with it once you're done translating the UI, and it should be pretty easy from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants