New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for nb, nn #57

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jhsoby
Contributor

jhsoby commented Oct 14, 2016

Please let me know if there's something else that's needed to set up this tool for those languages.

jhsoby added some commits Oct 14, 2016

Adding configuration for Norwegian Bokmål and Norwegian Nynorsk. Plea…
…se let me know if there's something else that's needed to set up this tool for those languages.
Making buttons use MediaWiki style
Same style as the buttons used in the Vector skin.

@jhsoby jhsoby changed the title from Adding configuration for Norwegian Bokmål and Norwegian Nynorsk. to Configuration for nb, nn; changing button style to Vector style Oct 14, 2016

@eggpi

Really cool, thank you very much for all this! I managed to run nb on my local instance:

screen shot 2016-10-14 at 19 47 37 pm

I needed a couple of tiny tweaks to the config, which I'm suggesting as comments, but otherwise I'm excited to merge this! If you want to try it out yourself, the instructions are here, but I can do this kind of basic testing myself.

As for the CSS change, I think it fits well with making the "Nope, next" button less negative (I was considering that and other UI stuff in #54), and I like it overall, but I'm not totally convinced we need to copy MediaWiki exactly.

In particular, since the buttons are one of the few UI elements we have, and they're so prominent, I'd like them to look a bit less flat and more "clickable" (hence the existing box-shadow stuff). I can take another look at this in a few days and try out some ideas on top of your patch, though. Maybe you could have that commit in a separate PR so we can merge the configs and iterate a bit on the CSS?

Again, thank you so much for this!

],
),
nn = dict(

This comment has been minimized.

@eggpi

eggpi Oct 14, 2016

Owner

It looks like we don't have a translation for this one yet, right? Can you take care of that please? I did manage to try out the config locally, it it looks mostly fine.

However, I ended up with only 579 snippets. This is not a problem in itself, but maybe there are other templates, or alternate spellings of the existing templates, that can be added to citation_needed_templates? Sorry these have to be specified explicitly for now, I haven't got around to working on #51 yet :(

This comment has been minimized.

@jhsoby

jhsoby Oct 14, 2016

Contributor

579 doesn't sound wrong actually, it's a pretty small wiki. They have ~2000 articles in the category for missing references, but most of those are via a general template saying that the entire article is missing references.

Translation is done now, by the way, so I guess Nikerabbit will add it in a day or two.

config.py Outdated
lead_section_policy_link = 'https://no.wikipedia.org/wiki/Wikipedia:Bruk_av_kilder#Hvorfor_siterer_vi_kilder',
lead_section_policy_link_title = 'Wikipedia:Bruk_av_kilder',
citation_needed_category = 'Artikler som trenger referanser',

This comment has been minimized.

@eggpi

eggpi Oct 14, 2016

Owner

Category names need to use underscores instead of spaces: Artikler_som_trenger_referanser, please.

config.py Outdated
wikilink_prefix_blacklist = EN_WIKILINK_PREFIX_BLACKLIST,
tags_blacklist = EN_TAGS_BLACKLIST,
templates_blacklist = EN_TEMPLATES_BLACKLIST,
hidden_category = 'Skjulte kategorier',

This comment has been minimized.

@eggpi

eggpi Oct 14, 2016

Owner

Underscores here and also in the same places for nn, please.

@@ -106,30 +106,44 @@ button:focus {
margin-bottom: 40px;
}

This comment has been minimized.

@eggpi

eggpi Oct 14, 2016

Owner

No need for these blank lines, right?

This comment has been minimized.

@jhsoby

jhsoby Oct 14, 2016

Contributor

No, those were a mistake I didn't notice until I commited. I'm still quite a newbie at this Git thing, so I'm not sure how to fix that after I commited.

text-decoration: none;
color: black;
font-weight: bold;
font-size:1em;

This comment has been minimized.

@eggpi

eggpi Oct 14, 2016

Owner

Nitpick: please add spaces after the : for consistency with the rest of the file.

This comment has been minimized.

@jhsoby

jhsoby Oct 14, 2016

Contributor

👍

jhsoby added some commits Oct 14, 2016

Update config.py
underscores in category names
Update style.css
Spaces after colons
Update style.css
reverting to original state, moving proposed changes to different branch

@jhsoby jhsoby changed the title from Configuration for nb, nn; changing button style to Vector style to Configuration for nb, nn Oct 14, 2016

@eggpi

This comment has been minimized.

Owner

eggpi commented Oct 14, 2016

Great, merged this as 7c5c634! I'll enable nb on Tools Labs, but we'll still need to wait for the nn translation to be committed to this repository by the Translate Wiki people. Thank you!

Oh and by the way, if you're having trouble with git, you may be interested in learning about git rebase, which lets you make changes to your history after committing. This seems to be a good tutorial. I use it a lot on pull requests like this: make a change, use git rebase to clean up the branch, then git push -f to update it.

@eggpi eggpi closed this Oct 14, 2016

@eggpi

This comment has been minimized.

Owner

eggpi commented Nov 1, 2016

Hey, these are now live!

https://tools.wmflabs.org/citationhunt/nn
https://tools.wmflabs.org/citationhunt/nb

By the way, it's worth mentioning that most of the traffic for English CH comes from links spread out in relevant pages on that Wikipedia (e.g, in https://en.wikipedia.org/wiki/Wikipedia:Citation_needed). It might make sense to do something like that here, too.

Anyway, thanks again for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment