Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build promise resolves before types are emitted #597

Merged
merged 3 commits into from Apr 1, 2022
Merged

fix: build promise resolves before types are emitted #597

merged 3 commits into from Apr 1, 2022

Conversation

phshy0607
Copy link
Contributor

@phshy0607 phshy0607 commented Mar 31, 2022

Fix #562

I tried to fix this. All tests are passed.

The fixes are

  • make parentPort postMessage before close
  • make dts build a promise

@vercel
Copy link

@vercel vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/tsup/GxUhv4cncEeL9Ey9QfKGqcGUBvSH
Preview: https://tsup-git-fork-phshy0607-fix-resolves-before-dts-egoist.vercel.app

@egoist egoist merged commit d30f813 into egoist:dev Apr 1, 2022
6 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 5.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants