Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update rollup and rollup-plugin-dts to latest versions

Merged
merged 1 commit into from May 25, 2022

Conversation

oscarnewman
Copy link
Contributor

@oscarnewman oscarnewman commented May 19, 2022

Hi there,

Not sure if this will truly be helpful or not, but wanted to try.

I've run into an issue in building out a new library with tsup where the pinned version of rollup-plugin-dts doesn't support types with negative numbers as keys, such as:

type Foo = {
 [-1]: string
}

I ran into this trying to setup a design system library with https://vanilla-extract.style.

I've setup a minimal reproduction of the issue here: https://github.com/oscarnewman/tsup-repro

In my testing, updating rollup-plugin-dts (and rollup as is required by it's new peer-dep version) fixes this issue, and the test suite passes locally for me.

We've currently just switched to running a fork with these updates at @oscarnewman/tsup but would love to help out anyone else who's also faced this issue.

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tsup Ready (Inspect) Visit Preview May 19, 2022 at 8:16PM (UTC)

@oscarnewman oscarnewman changed the title [Deps] Update rollup and rollup-plugin-dts to latest versions chore(deps): Update rollup and rollup-plugin-dts to latest versions May 19, 2022
@egoist egoist merged commit 27984cf into egoist:dev May 25, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants