Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore esbuild warning if silent is true

Merged
merged 1 commit into from Jun 5, 2022

Conversation

ArcherGu
Copy link
Contributor

@ArcherGu ArcherGu commented May 31, 2022

I don't know if you did it here on purpose or forgot to modify it. When I set silent: true, some esbuild warning messages are still printed. I felt it was a bug and therefore fixed it.

Also, if we don't pay attention to the format of the print, can we use Logger to print esbuild warning messages, which can reduce the dependence of consola. 馃檪

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

Name Status Preview Updated
tsup Ready (Inspect) Visit Preview May 31, 2022 at 5:48AM (UTC)

@egoist egoist merged commit 36e2199 into egoist:dev Jun 5, 2022
6 checks passed
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

馃帀 This PR is included in version 6.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@ArcherGu ArcherGu deleted the fix-esbuild-warn-log-when-silent branch Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants