Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[Patch:3562570] Shortest Path Fingerprinter #18

Closed
wants to merge 6 commits into from

3 participants

@johnmay

Patch from Asad mainly containing new classes.
Adds a new external dependency (commons-math) which could be applied to other areas that are currently doing their own arithmetic.
Checked tests and code, signed off

Tracker: http://sourceforge.net/tracker/?group_id=20024&atid=320024

asad added some commits
@asad asad added commons math library Signed-off-by:Syed Asad Rahman <s9asad@gma…
…il.com>

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
450c1e2
@asad asad added code dependencies for the Shortest path fingerprinter Signed-of…
…f-by:Syed Asad Rahman <s9asad@gmail.com>

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
a10bf51
@asad asad added test case Signed-off-by:Syed Asad Rahman <s9asad@gmail.com>
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
d6d2210
@asad asad added test case to test module Signed-off-by:Syed Asad Rahman <s9asad…
…@gmail.com>

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
8495658
@asad asad added ShortestPathFingerprinter with recommended changes Signed-off-b…
…y:Syed Asad Rahman <s9asad@gmail.com>

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
498b2de
@asad asad added ShortestPathFingerprinter with recommended changes Signed-off-b…
…y:Syed Asad Rahman <s9asad@gmail.com>

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
1992eca
@egonw
Owner

I will apply this, per what we agreed on.

I do have these additional comments. Do you prefer me to file them as bug reports too?

  • missing JavaDoc for some public classes and methods
  • missing test classes for SimpleAtomCanonicalisation and RandomNumber
  • SimpleAtomCanonicalisation and RandomNumber should be part of the fingerprint module and not standard, where they are used

Egon

@egonw egonw closed this
@egonw
Owner

Oh, very important:

  • add the missing commons-math-**.jar.meta file

the content has version, name, copyright/license info for the library, like this one for xpp3-1.1.4c.jar:

[xpp3-1.1.4c.jar]
Library=XML Pull Parser
Version=1.1.4c
Copyright=(c) 2001 Extreme! Lab, Indiana University. All rights reserved.
License=Indiana University Extreme! Lab Software License
LicenseURL=http://www.extreme.indiana.edu/viewcvs/~checkout~/XPP3/LICENSE.txt
Download=http://www.extreme.indiana.edu/xgws/xsoap/xpp/download/old_versions/
SourceCode=http://www.extreme.indiana.edu/xgws/xsoap/xpp/download/old_versions/
Homepage=http://www.extreme.indiana.edu/xgws/xsoap/xpp/

@egonw
Owner

Perhaps useful:

$ more jar/template.jar.meta
[template.jar]
Library=
#Version=
#Copyright=
#License=
#LicenseURL=
#Download=
#SourceCode=
#Homepage=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 30, 2012
  1. @asad @johnmay

    added commons math library Signed-off-by:Syed Asad Rahman <s9asad@gma…

    asad authored johnmay committed
    …il.com>
    
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
  2. @asad @johnmay

    added code dependencies for the Shortest path fingerprinter Signed-of…

    asad authored johnmay committed
    …f-by:Syed Asad Rahman <s9asad@gmail.com>
    
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
  3. @asad @johnmay

    added test case Signed-off-by:Syed Asad Rahman <s9asad@gmail.com>

    asad authored johnmay committed
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
  4. @asad @johnmay

    added test case to test module Signed-off-by:Syed Asad Rahman <s9asad…

    asad authored johnmay committed
    …@gmail.com>
    
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
  5. @asad @johnmay

    added ShortestPathFingerprinter with recommended changes Signed-off-b…

    asad authored johnmay committed
    …y:Syed Asad Rahman <s9asad@gmail.com>
    
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
  6. @asad @johnmay

    added ShortestPathFingerprinter with recommended changes Signed-off-b…

    asad authored johnmay committed
    …y:Syed Asad Rahman <s9asad@gmail.com>
    
    Signed-off-by: John May <john.wilkinsonmay@gmail.com>
Something went wrong with that request. Please try again.