Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise return annotations from doctrine/lexer #209

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@nicolas-grekas
Copy link
Contributor

commented Aug 12, 2019

In order to help the ecosystem move forward with return types, the next version of Symfony will trigger deprecation notices when a child class doesn't declare the return type of one of its overriding methods.

This happens only for methods overriding third party packages.

The goal is that child classes move to add return types first so that vendors can then seamlessly add them too in their next major version bump.

The related PR is symfony/symfony#30323
And this package is the last that triggers a notice with the new system:
https://travis-ci.org/symfony/symfony/jobs/570902186

Adding these annotations allows opting-out from the notices, meaning "I cannot add the return-type now because that'd be a BC break, but I'm aware that's something I need to fix when bumping to the next major of my package".

A quick merge would be greatly appreciated as that would unlock progress on our side :)

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

🙏 could you merge please?

@egulias

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Yes, sorry @nicolas-grekas. Do you know why is Travis is unable to install PHP5.5?
Should this version be removed from the matrix?

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:ret-annot branch from 0e78978 to f01b3c1 Aug 13, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@egulias green now, I added dist: trusty and it fixed it. Travis might have changed its default base image.

@egulias egulias merged commit 92dd169 into egulias:master Aug 13, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Inspection Summary
Details
Node: scrutinizer__default
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.