Fix a bug causing bools (and other subclasses) to get incorrectly serialized #4

Merged
merged 1 commit into from Mar 5, 2013

1 participant

@ghost

Without this fix, bools would be deserialized as ints, e.g. getting a key that was set as True would return 1.

In general, it seems like the right thing to do to make sure we always get out exactly the same type that we set, without any room for error.

Marshall Quander Fix serialization of int/str subclasses, e.g. bool
Without this fix, bools would be deserialized as ints, e.g.
getting a key that was set as True would return 1.
5b9926c
@eguven
Owner

I was worried that this might cause issues for existing users but the correct approach is

get out exactly the same type we set

as you suggest. There is no point continuing old mistake.

@eguven eguven merged commit 2d707cc into eguven:master Mar 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment