From ebb95cb2b84c301596bb0f779d3088f025e8bc73 Mon Sep 17 00:00:00 2001 From: ehmicky Date: Mon, 20 May 2019 10:00:00 +0200 Subject: [PATCH] Change default value of `verbose` --- README.md | 10 ++++++---- docs/API.md | 10 ++++++---- examples/stream.gulpfile.js | 3 +-- package-lock.json | 4 +++- package.json | 1 - src/options/main.js | 3 +-- 6 files changed, 17 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index 2844606..6a5fddb 100644 --- a/README.md +++ b/README.md @@ -162,16 +162,18 @@ The following options are also available. ## echo -_Type_: `boolean`
_Default_: same as [`verbose`](#verbose) +_Type_: `boolean`
_Default_: `true` for [`task()`](#taskfunction-options) +and [`exec()`](#execfunction-options), `false` for +[`stream()`](#streamfunction-options). Whether the `command` should be printed on the console.
[Full documentation](https://github.com/ehmicky/gulp-execa/blob/master/docs/API.md#echo). ## verbose -_Type_: `boolean`
_Default_: `true` when -[in CI](https://github.com/watson/is-ci) and -[`stream()`](#streamfunction-options) is not used. `false` otherwise. +_Type_: `boolean`
_Default_: `true` for [`task()`](#taskfunction-options) +and [`exec()`](#execfunction-options), `false` for +[`stream()`](#streamfunction-options). Whether both the `command` and its output (`stdout`/`stderr`) should be printed on the console. diff --git a/docs/API.md b/docs/API.md index 3aa2a3a..6dd62af 100644 --- a/docs/API.md +++ b/docs/API.md @@ -76,7 +76,9 @@ _Type_: `object` #### echo -_Type_: `boolean`
_Default_: same as [`verbose`](#verbose) +_Type_: `boolean`
_Default_: `true` for [`task()`](#taskfunction-options) +and [`exec()`](#execfunction-options), `false` for +[`stream()`](#streamfunction-options). Whether the `command` should be printed on the console. @@ -90,9 +92,9 @@ $ gulp audit #### verbose -_Type_: `boolean`
_Default_: `true` when -[in CI](https://github.com/watson/is-ci) and -[`stream()`](#streamfunction-options) is not used. `false` otherwise. +_Type_: `boolean`
_Default_: `true` for [`task()`](#taskfunction-options) +and [`exec()`](#execfunction-options), `false` for +[`stream()`](#streamfunction-options). Whether both the `command` and its output (`stdout`/`stderr`) should be printed on the console. diff --git a/examples/stream.gulpfile.js b/examples/stream.gulpfile.js index 06b84a8..d0078e2 100644 --- a/examples/stream.gulpfile.js +++ b/examples/stream.gulpfile.js @@ -14,5 +14,4 @@ const { src } = require('gulp') const { stream } = require('gulp-execa') module.exports.default = () => - src('**/*') - .pipe(stream(({ path }) => `echo ${path}`, { echo: true })) + src('**/*').pipe(stream(({ path }) => `echo ${path}`, { echo: true })) diff --git a/package-lock.json b/package-lock.json index 727e4db..e210e10 100644 --- a/package-lock.json +++ b/package-lock.json @@ -2136,7 +2136,8 @@ "ci-info": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/ci-info/-/ci-info-2.0.0.tgz", - "integrity": "sha512-5tK7EtrZ0N+OLFMthtqOj4fI2Jeb88C4CAZPu25LDVUgXJ0A3Js4PMGqrn0JU1W0Mh1/Z8wZzYPxqUrXeBboCQ==" + "integrity": "sha512-5tK7EtrZ0N+OLFMthtqOj4fI2Jeb88C4CAZPu25LDVUgXJ0A3Js4PMGqrn0JU1W0Mh1/Z8wZzYPxqUrXeBboCQ==", + "dev": true }, "ci-parallel-vars": { "version": "1.0.0", @@ -5916,6 +5917,7 @@ "version": "2.0.0", "resolved": "https://registry.npmjs.org/is-ci/-/is-ci-2.0.0.tgz", "integrity": "sha512-YfJT7rkpQB0updsdHLGWrvhBJfcfzNNawYDNIyQXJz0IViGf75O8EBPKSdvw2rF+LGCsX4FZ8tcr3b19LcZq4w==", + "dev": true, "requires": { "ci-info": "^2.0.0" } diff --git a/package.json b/package.json index 4cbb648..a54df7a 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,6 @@ "core-js": "^3.1.0", "execa": "sindresorhus/execa#c8a53da6748885423f73812580afd59699b36e31", "fancy-log": "^1.3.3", - "is-ci": "^2.0.0", "jest-validate": "^24.8.0", "keep-func-props": "^1.3.2", "plugin-error": "^1.0.1", diff --git a/src/options/main.js b/src/options/main.js index ea80bc4..5dbfcfd 100644 --- a/src/options/main.js +++ b/src/options/main.js @@ -1,5 +1,4 @@ import { validate } from 'jest-validate' -import isCi from 'is-ci' import { isPlainObject, pickBy } from '../utils.js' import { throwError, handleError } from '../error.js' @@ -45,7 +44,7 @@ const validateOpts = function({ opts }) { } const DEFAULT_OPTS = { - verbose: isCi, + verbose: true, } const EXAMPLE_OPTS = {