Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples of how to fire process errors #21

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@Hongarc
Copy link
Contributor

commented May 15, 2019

I am reading your source code(read an example first) and I have a question:

Why you call setTimeout inside setTimeout? Are we need it?

This commit remove some eslint-disable rules.

  • I have read the contribution guidelines.
  • I have added tests (we are enforcing 100% test coverage).
  • I have added documentation in the README.md, the docs directory (if
    any) and the examples directory (if any).
  • The status checks are successful (continuous integration). Those can be
    seen below.
@ehmicky
Copy link
Owner

left a comment

Thanks for looking into this @Hongarc!
No the setTimeout was needed but not anymore. It can be removed.
I had only one comment.
I've updated the examples on repl.it as well.

Show resolved Hide resolved examples/errors.js Outdated

@ehmicky ehmicky changed the title Fix rule eslint Improve examples of how to fire process errors May 15, 2019

@ehmicky ehmicky merged commit 0d81615 into ehmicky:master May 16, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 782ae6b...329436e
Details
codecov/project 100% remains the same compared to 782ae6b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ehmicky

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

@all-contributors please add @Hongarc for code as well.

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@ehmicky

I've put up a pull request to add @Hongarc! 🎉

@Hongarc Hongarc deleted the Hongarc:error branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.