fix: plot.gg_partial* return single patchwork figure instead of named list (#77)

[ehrlinger]

What this does

Fixes the inconsistent return type from plot.gg_partial(), plot.gg_partial_rfsrc(), and plot.gg_partialpro().

Before: when both continuous and categorical predictors were present, these functions returned list(continuous = <ggplot>, categorical = <ggplot>) — a surprise to users and ambiguous for autoplot().

After: always returns a single ggplot/patchwork object. When both panel types are present they are combined vertically with patchwork::wrap_plots(gg_cont, gg_cat, ncol = 1). inherits(p, "ggplot") is TRUE for both single and combined cases.

Changes

• R/plot.gg_partial.R — replace list(...) return with patchwork::wrap_plots() at all 3 return sites; update @return docs; add @importFrom patchwork wrap_plots
• DESCRIPTION — patchwork moved from Suggests to Imports
• NAMESPACE — importFrom(patchwork, wrap_plots) regenerated
• NEWS.md — entry added under v2.7.3
• Tests updated: list-structure assertions → expect_s3_class(out, "ggplot"); expect_ggplot_result() helper removed from autoplot tests

Test plan

• devtools::test() — 677 pass, 0 fail
• plot(gg_partial(...)) returns a single ggplot when both variable types present
• autoplot(gg_partial(...)) returns a single ggplot
• Single-type case (continuous only or categorical only) unchanged

Closes #77.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.18%. Comparing base (24fc3cc) to head (c098bd5).

Files with missing lines	Patch %	Lines
R/plot.gg_partial.R	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          32       32           
  Lines        2403     2403           
=======================================
  Hits         2023     2023           
  Misses        380      380           

Files with missing lines	Coverage Δ
R/plot.gg_partial.R	78.67% <66.66%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR fixes inconsistent return types for plot.gg_partial(), plot.gg_partial_rfsrc(), and plot.gg_partialpro() by ensuring they always return a single plot object (a ggplot or patchwork composition) rather than sometimes returning a named list of plots when both continuous and categorical predictors are present.

Changes:

• Updated plot.gg_partial* methods to combine continuous + categorical panels with patchwork::wrap_plots(..., ncol = 1) instead of returning list(continuous=..., categorical=...).
• Promoted patchwork from Suggests to Imports, and updated NAMESPACE/roxygen docs accordingly.
• Updated tests and documentation to reflect the new single-object return type.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
R/plot.gg_partial.R	Switches combined output from a named list to a single patchwork plot; updates roxygen return docs and imports.
DESCRIPTION	Moves patchwork into Imports to support unconditional runtime usage.
NAMESPACE	Adds importFrom(patchwork, wrap_plots).
NEWS.md	Documents the behavior change for plot.gg_partial* return types.
man/plot.gg_partial.Rd	Updates return-value documentation to describe patchwork composition.
man/plot.gg_partial_rfsrc.Rd	Updates return-value documentation to describe patchwork composition.
man/plot.gg_partialpro.Rd	Updates return-value documentation to describe patchwork composition.
tests/testthat/test_gg_partial.R	Adjusts expectations for combined continuous+categorical plotting to be a single ggplot-inheriting object.
tests/testthat/test_gg_partialpro.R	Adjusts expectations for combined continuous+categorical plotting to be a single ggplot-inheriting object.
tests/testthat/test_autoplot.R	Simplifies autoplot assertions now that outputs are consistently ggplot-inheriting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.