Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres db connector #5

Merged
merged 3 commits into from May 28, 2022
Merged

Conversation

rotiv13
Copy link
Contributor

@rotiv13 rotiv13 commented May 27, 2022

Initial commit for some feedback on what the postgres connector can improve as this is a really simple solution for the connection to the database and don't know what pitfalls it might have until I look at it better

@ehsaniara
Copy link
Owner

ehsaniara commented May 28, 2022

Looks good, Thanks!

There is a known issue with the Redis Lock. Redis container is missing on Github Workflow

@ehsaniara ehsaniara merged commit c5a7d7e into ehsaniara:main May 28, 2022
@ehsaniara ehsaniara linked an issue May 28, 2022 that may be closed by this pull request
@ehsaniara
Copy link
Owner

Redis container added on Github Workflow, the test is green now.

@rotiv13
Copy link
Contributor Author

rotiv13 commented May 30, 2022

@ehsaniara this was an initial draft there is a problem with this implementation. which if for some reason the lock doesn't get deleted it will be locked forever and it needs manual intervention. I would like to implement a clean up which would check if a lock is expired based on the ttl and the now time both when trying to acquire the lock and when starting up the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgresDB Support
2 participants