Skip to content

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 17, 2025

Simple geometry, not used anymore.

Simple geometry, not used anymore.
@github-actions github-actions bot added topic: calorimetry topic: far-forward Deterctors for small-angle particles labels Nov 17, 2025
@veprbl veprbl requested review from rymilton and sebouh137 December 1, 2025 20:50
@rymilton
Copy link
Contributor

rymilton commented Dec 1, 2025

I just checked all of the ZDC xml files in compact/far_forward/ and indeed it looks like the detector type ZDC_ECAL defined in src/ZeroDegreeCalorimeterEcal_geo.cpp isn't used anywhere.

@sebouh137 Could you please confirm that you weren't using this file? You and Barak did more work with the ECAL than I did. The LYSO ECAL uses src/ZDC_Crystal_geo.cpp.

@veprbl veprbl requested a review from bschmookler December 1, 2025 21:37
@bschmookler
Copy link
Contributor

Yes, we only used the ZDC_Crystal_geo.cpp for our studies.

@veprbl veprbl merged commit 797bdd5 into main Dec 2, 2025
152 of 153 checks passed
@veprbl veprbl deleted the pr/rm_old_zdc branch December 2, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: calorimetry topic: far-forward Deterctors for small-angle particles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants