CalorimeterIslandCluster: allow specifying adjacency matrix in terms of cellID fields #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the current implementation is that
is_neighbour()relies on geometrical dimensions of a calorimeter being used. This makes it cumbersome and error-prone to enable clustering for different detectors. The goal is to instead use readout cellID fields.This PR suggests a following interface for doing that: A new parameter
adjacencyMatrixis added to describe the adjacency of the sensitive elements. It can be used replace the existing settings likelocalDistXY. The value specified must be a string expression (to be evaluated by DD4hep evaluator) that returns a "boolean" value which is non-zero for adjacent cells. An example predicate for a calorimeter with a readout ID spec likesystem:8,row:8,column:8could look likeA calorimeter that has sectors might require a more sophisticated predicate like:
There are few minor issues with the current implementation:
5is a magical constant for number of rows per sector. It is possible to scan the geometry and define some sort ofrow_maxconstant to be used in place.