Skip to content

Add test suite url to start-etos span attributes #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2025
Merged

Add test suite url to start-etos span attributes #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a145b1
Add suite url to the start-etos span attributes
Oct 22, 2025
274eadf
Fix pyproject test dependencies
Oct 22, 2025
39d933c
Remove newline mistake
Oct 22, 2025
42efb5a
Add test suite URL to v1alpha start-etos span
Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@ Homepage = "https://github.com/eiffel-community/etos-api"
Repository = "https://github.com/eiffel-community/etos-api"

[project.optional-dependencies]
testing = ["pytest", "pytest-cov"]
testing = [
"pytest",
"pytest-cov",
"tox",
"pytest-asyncio",
"httpx"
]

[tool.build_sphinx]
source_dir = "docs"
Expand Down
1 change: 1 addition & 0 deletions python/src/etos_api/routers/v0/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ async def _start(etos: StartEtosRequest, span: Span) -> dict: # pylint:disable=
span.set_attribute("etos.id", tercc.meta.event_id)

LOGGER.info("Validating test suite.")
span.set_attribute("etos.test_suite.uri", etos.test_suite_url)
await validate_suite(etos.test_suite_url)
LOGGER.info("Test suite validated.")

Expand Down
1 change: 1 addition & 0 deletions python/src/etos_api/routers/v1alpha/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ async def _create_testrun(etos: StartTestrunRequest, span: Span) -> dict:
span.set_attribute("etos.id", testrun_id)

LOGGER.info("Download test suite.")
span.set_attribute("etos.test_suite.uri", etos.test_suite_url)
test_suite = await download_suite(etos.test_suite_url)
LOGGER.info("Test suite downloaded.")

Expand Down
Loading