fix(monero-sys): Correctly handle multiple transaction keys #629
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…the transaction id for each tx key as well
…UnstoppableSwap/core into fix/monero-sys-multiple-tx-keys
This is annoying because it's increasing the diff size when I really just want to extract the changes into a patch.
…tput. Caviat: we currently skip all outputs that belong to the primary address. This means we won't have a tx key when sending to our own main address or for change outputs. Transactions which try anyway will fail in the rust verification step.
…our own main address
|
bugbot run |
|
Skipping Bugbot: Bugbot is disabled for this repository |
|
bugbot run |
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…n fails (instead of ignoring it)
|
whats blocking this from being merged? Maybe we can get a Monero developer to review our C++ patch? |
|
@SNeedlewoods Would you be interested in looking over our C++ patch here? |
|
@jeffro256 thanks for the review! have you had a chance to look at the monero-sys/patches/eigenwallet_0003_pending_transaction_tx_keys.patch C++ patch? This is what we are most unsure about and where we are afraid to make mistakes. |
|
bugbot run |
Einliterflasche
force-pushed
the
fix/monero-sys-multiple-tx-keys
branch
from
a8056f1 to
37af555
Compare
|
The remaining failing ci checks (failed build on for windows, some integration tests) aren't cause by this PR: the tests were already failing beforehand and the windows build seems to be a temporary sourceforge problem. Merging this now. |
Note
Expose per-output Monero transaction keys via FFI and return them from
TxReceipt, update harness/swap to use them (incl. subaddress tip), add new monero transfer-proof tests, and wire into CI.PendingTransaction::txKeys(...)and plumb through C++ bridge to Rust asVec<TxKey { txid, address, key }>.TxReceiptto return per-output tx keys asHashMap<Address, PrivateKey>; update publish/validation to require single txid and keys for all specified outputs (incl. subaddresses).WalletHandle::address(...), makecheck_tx_statuspublic, tweak logging filters.Cli; addnew_with_sync_specified(..., background_synced); addcheck_tx_key; minor sync/balance handling.tx_keysmap (select key for lock address); support developer tip to a subaddress; addhappy_path_alice_developer_tip_subaddresstest.monero-tests:transfers,transfers_wrong_key) using harness; verify correct and incorrect tx keys.monero-testsand added swap subaddress test;justfileaddsundo-monero-changes.Written by Cursor Bugbot for commit b69ec7c. This will update automatically on new commits. Configure here.