Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: master
Commits on Jun 20, 2014
  1. Update README

  2. Support HTTPS urls.

    If we call `set_domain` with a URL with an explicit scheme then we
    should use that scheme. If we omit the scheme then we should default to
    standard HTTP requests
Commits on Jun 19, 2014
  1. Remove dead code

  2. Remove module incusion/extension

    Now there's no weird meta and we're just dealing with methods in classes
    we can stop with the modules and just wrap some stuff in `class << self`
  3. Convert from class to instance methods

    so that we can wrap multiple checks inside a single test.
  4. use set_domain method

    Rather than reaching straight in to use the attr_writer on the class.
  5. MiniTest::Unit::TestCase is now MiniTest::Test

    fix all the references from the old MiniTest::Unit::TestCase and the
    even older Test::Unit::TestCase to the new MiniTest::Test
  6. Move minitest requirement into the rakefile

    So that it doesn't get accidentally loaded twice when the rake default
    test task hoovers up all the files in test/ when loading all it's files
  7. Remove Turn

    The newest versions of MiniTest have much better output formatters than
    they used to
  8. Integration test framework.

    We need a consistent service to properly test this library.
    This commit adds a small sinatra app that contains endpoints that behave
    predicatble and allows us to run some integration tests against this app
    from a Rake task.
    Note that the `rake integration_test` sends `kill -9` to the Sinatra
    process after it's done. This is ungraceful and a bit nasty, but we don't
    want zombie processes hanging around.
    As part of this commit we've narrowed down the default test task to
    *only* run the unit tests.
    Also note that the "integration test" in this commit doesn't test any
    part of our library - only that the test app is started correctly.
Commits on Jun 18, 2014
  1. Remove local variable

  2. Prefer !! to ternary

  3. use [] notation for fetching headers.

    We're speculatively checking whether a header exists or not, so nil is
    an acceptable response.
    using [] in this case makes more sense than a nil guard and a fetch!
    Also clean up the unit tests around this to actually set the header
    values in our test object rather than stubbing the hash interface.
    This couples us to some internal implementation of Net/HTTP (the
    `initialize_http_header` method in `Net::HTTPHeader`) but this is in my
    opinion slightly better than stubbing it's hash like interface.
    We're coupled to it's implementation either way - but this way is
    slightly more intention revealing.
  4. Clean up requires.

    Move all the requires into the top level of the lib directory and
    require everything in order when you `require 'http_redirect_test'` the
    individual components of this gem are not designed to be used separately.
  5. Modernise.

    This commit tidies up some infrastructure around this library. Namely:
    + Introduce Bundler to manage gem deps
    + tidy up load paths and `requires` to be more idiomatic for Ruby 2.0
    + Switch the tests to use minitest rather than test/unit
    + Provide pretty minitest ouput using Turn
Commits on May 19, 2011
Commits on Oct 21, 2010
  1. version 0.1.3

  2. un break the test task.


Something went wrong with that request. Please try again.