Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

BL and Normal Coordinate Transformation : Confusion in Names! #115

Closed
shreyasbapat opened this issue Mar 14, 2019 · 3 comments
Closed

BL and Normal Coordinate Transformation : Confusion in Names! #115

shreyasbapat opened this issue Mar 14, 2019 · 3 comments

Comments

@shreyasbapat
Copy link
Member

@shreyasbapat shreyasbapat commented Mar 14, 2019

馃悶 Problem

There is lot of confusion in coordinates transformation!
bl_coord_transforms and coord_transforms are not good names as in the coord_transforms does not specify the type of coordinates it works on while bl_coord_transforms clearly tells user what the module does! There is a need to make the coord transforms more intuitive.

馃幆 Goal

Make coordinate transformations more intuitive in EinsteinPy

馃挕 Possible solutions

  • Rename coord_transforms.py
  • Merge both files into one
  • Think of some other solution?

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #115
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 馃帀
@ritzvik
Copy link
Member

@ritzvik ritzvik commented Mar 15, 2019

How about we create a separate module called coords in Einsteinpy.
We can have sph_crt.py for Spherical<->Cartesian conversions, bl_crt.py for Boyer-Lindquist<->Cartesian conversions & maybe sph_bl.py for spherical<->Boyer-Lindquist conversions.

Still the names feel weird. Any suggestions?

Loading

@raphaelreyna
Copy link
Contributor

@raphaelreyna raphaelreyna commented Mar 15, 2019

It may possibly be too heavy handed, but what about subclassing numpy.array to make a vector class that knows what its current coordinate system is and how to convert itself to any other given coordinate system?

Loading

@ritzvik
Copy link
Member

@ritzvik ritzvik commented Mar 16, 2019

It may possibly be too heavy handed, but what about subclassing numpy.array to make a vector class that knows what its current coordinate system is and how to convert itself to any other given coordinate system?

Maybe, it's a long shot. But we'll keep it in tabs. Open an issue wherever necessary.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants