Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isort conflicts with Black #185

Closed
rishi-s8 opened this issue Apr 11, 2019 · 1 comment 路 Fixed by #205
Closed

Isort conflicts with Black #185

rishi-s8 opened this issue Apr 11, 2019 · 1 comment 路 Fixed by #205
Labels
bug Something isn't working Upstream
Milestone

Comments

@rishi-s8
Copy link
Member

rishi-s8 commented Apr 11, 2019

馃悶 Problem
Isort and black are formatting import differently in coordinates/__init__.py

Referencing psf/black#127
Referencing reopened PyCQA/isort#694

Temporary Solution:
Add # isort: skip in front of the import.
Implemented in #176

馃枼
Issue with the following versions:
isort v4.3.17
black v19.3b0

馃幆 Goal
Remove the temporary fix of isort: skip in coordinates/__init__.py

馃挕 Possible solutions
Wait till the Issue is solved in Black or Isort

@shreyasbapat shreyasbapat added bug Something isn't working Upstream labels Apr 11, 2019
@shreyasbapat
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants