Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate conversion inside plotting module not handled correctly #277

Closed
ritzvik opened this issue Jul 2, 2019 · 3 comments
Closed

Coordinate conversion inside plotting module not handled correctly #277

ritzvik opened this issue Jul 2, 2019 · 3 comments
Labels
bug Something isn't working coordinates plotting
Milestone

Comments

@ritzvik
Copy link
Member

ritzvik commented Jul 2, 2019

🐞 Problem
Earlier, plotting was written with Schwarzschild in mind, which relies on Spherical Coordinates only. But as the plotting was extended for Geodesic object, it inherently deals with Kerr & KerrNewman also. The coordinate conversion inside ScatterGeodesicPlotter and StaticGeodesicPlotter is not taken care by coordinates module and the design assumes Spherical to Cartesian conversion by default(No BL taken in consideration). This leads to wrong calculations.

See https://github.com/einsteinpy/einsteinpy/blob/master/src/einsteinpy/plotting/geodesics/geodesics_scatter.py#L62-L63

🎯 Goal

  • Fix this

💡 Possible solutions

  • Maybe, use return_cartesian = True in calculate_trajectory() to get values directly in x,y,z form.

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@ritzvik
Copy link
Member Author

ritzvik commented Jul 2, 2019

@shreyasbapat @Varunvaruns9 , kind of an urgent problem!

@ritzvik ritzvik added bug Something isn't working coordinates plotting labels Jul 2, 2019
@shreyasbapat
Copy link
Member

Oh my my!

This needs a fix!

@shreyasbapat
Copy link
Member

Closed in #274

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coordinates plotting
Projects
None yet
Development

No branches or pull requests

2 participants