You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🐞 Problem
Earlier, plotting was written with Schwarzschild in mind, which relies on Spherical Coordinates only. But as the plotting was extended for Geodesic object, it inherently deals with Kerr & KerrNewman also. The coordinate conversion inside ScatterGeodesicPlotter and StaticGeodesicPlotter is not taken care by coordinates module and the design assumes Spherical to Cartesian conversion by default(No BL taken in consideration). This leads to wrong calculations.
🐞 Problem
Earlier, plotting was written with
Schwarzschild
in mind, which relies on Spherical Coordinates only. But as the plotting was extended forGeodesic
object, it inherently deals withKerr
&KerrNewman
also. The coordinate conversion insideScatterGeodesicPlotter
andStaticGeodesicPlotter
is not taken care by coordinates module and the design assumes Spherical to Cartesian conversion by default(No BL taken in consideration). This leads to wrong calculations.See https://github.com/einsteinpy/einsteinpy/blob/master/src/einsteinpy/plotting/geodesics/geodesics_scatter.py#L62-L63
🎯 Goal
💡 Possible solutions
return_cartesian = True
incalculate_trajectory()
to get values directly in x,y,z form.📋 Steps to solve the problem
Addresses #<put issue number here>
The text was updated successfully, but these errors were encountered: