New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Create the coordinates module #139
Conversation
Class for Cartesian Coordinates and related transformations. | ||
""" | ||
|
||
@u.quantity_input(x=u.km, y=u.km, z=u.km) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep things in u.m
by default. We follow SI units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are dealing with orbits, no-one would ever give parameters in SI units. km is a convenient unit.
Class for Spherical Coordinates and related transformations. | ||
""" | ||
|
||
@u.quantity_input(r=u.km, theta=u.rad, phi=u.rad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also, change it to u.m
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 92.33% 91.65% -0.69%
==========================================
Files 18 16 -2
Lines 848 683 -165
==========================================
- Hits 783 626 -157
+ Misses 65 57 -8
Continue to review full report at Codecov.
|
Overridden by #176 |
Fixes #115
Partially fixes #121