Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create the coordinates module #139

Closed
wants to merge 4 commits into from
Closed

[WIP] Create the coordinates module #139

wants to merge 4 commits into from

Conversation

shreyasbapat
Copy link
Member

Fixes #115

Partially fixes #121

Class for Cartesian Coordinates and related transformations.
"""

@u.quantity_input(x=u.km, y=u.km, z=u.km)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep things in u.m by default. We follow SI units

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are dealing with orbits, no-one would ever give parameters in SI units. km is a convenient unit.

Class for Spherical Coordinates and related transformations.
"""

@u.quantity_input(r=u.km, theta=u.rad, phi=u.rad)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also, change it to u.m

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #139 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   92.33%   91.65%   -0.69%     
==========================================
  Files          18       16       -2     
  Lines         848      683     -165     
==========================================
- Hits          783      626     -157     
+ Misses         65       57       -8
Impacted Files Coverage Δ
src/einsteinpy/utils/kerr_utils.py 100% <0%> (ø) ⬆️
src/einsteinpy/utils/schwarzschild_utils.py 100% <0%> (ø) ⬆️
src/einsteinpy/metric/__init__.py 100% <0%> (ø) ⬆️
src/einsteinpy/constant.py 100% <0%> (ø) ⬆️
src/einsteinpy/metric/kerrnewman.py
src/einsteinpy/utils/kerrnewman_utils.py
src/einsteinpy/metric/schwarzschild.py 96.99% <0%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544f35f...0a2e76d. Read the comment docs.

@shreyasbapat
Copy link
Member Author

Overridden by #176
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean the Messed up utils! BL and Normal Coordinate Transformation : Confusion in Names!
3 participants