Add a Makefile for linux #31

Closed
GoogleCodeExporter opened this Issue Aug 23, 2015 · 9 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Makefile below is created by Julian Ospald (hasufell) 
julian.ospald@googlemail.com

Original issue reported on code.google.com by manuel.r...@gmail.com on 30 Apr 2012 at 7:40

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 pidgin)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 pidgin)

should be

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 purple)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 purple)

We don't need to link against all the pidgin stuff and this makes it compatible 
with finch-only setups.

Original comment by julian.o...@googlemail.com on 4 May 2012 at 3:44

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 pidgin)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 pidgin)

should be

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 purple)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 purple)

We don't need to link against all the pidgin stuff and this makes it compatible 
with finch-only setups.

Original comment by julian.o...@googlemail.com on 4 May 2012 at 3:44

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

The change from using the complete pidgin library to purple will cause the 
compiler to throw a couple of warnings due to unused variables but it doesn't 
seem to affect the functionality. Also, this allows libsteam to be used with 
Empathy via telepathy-haze.

Note: If used with Empathy, the SteamGuard request popup will not appear as it 
does with pidgin (and the login request will fail as not authorized). The 
request is sent to steam and a email is sent to the user as usual. The code can 
be put in the account's settings to gain access.

Original comment by canischa...@gmail.com on 1 Oct 2012 at 11:52

The change from using the complete pidgin library to purple will cause the 
compiler to throw a couple of warnings due to unused variables but it doesn't 
seem to affect the functionality. Also, this allows libsteam to be used with 
Empathy via telepathy-haze.

Note: If used with Empathy, the SteamGuard request popup will not appear as it 
does with pidgin (and the login request will fail as not authorized). The 
request is sent to steam and a email is sent to the user as usual. The code can 
be put in the account's settings to gain access.

Original comment by canischa...@gmail.com on 1 Oct 2012 at 11:52

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

Issue 40 has been merged into this issue.

Original comment by eionrobb on 21 Oct 2012 at 12:38

Issue 40 has been merged into this issue.

Original comment by eionrobb on 21 Oct 2012 at 12:38

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

Original comment by eionrobb on 21 Oct 2012 at 12:39

  • Changed state: Accepted

Original comment by eionrobb on 21 Oct 2012 at 12:39

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

Sorry, but how did you get the plugin to work with Empathy through 
transmission-haze? I can compile steam-mobile just fine using the attached 
Makefile, with the changes to link it only with libpurple. After placing the 
generated library on a folder that haze can pick it up from, the plugin shows 
up in empathy-accounts and I can start setting up an account, but the GUI does 
nothing after I click "Apply", it doesn't add the account at all.

mc-tool add haze/steam-mobile tells me there's no such protocol steam-mobile in 
connection manager haze too. I wonder if there's something I'm missing.

Original comment by miguelpontes on 3 Nov 2012 at 3:15

Sorry, but how did you get the plugin to work with Empathy through 
transmission-haze? I can compile steam-mobile just fine using the attached 
Makefile, with the changes to link it only with libpurple. After placing the 
generated library on a folder that haze can pick it up from, the plugin shows 
up in empathy-accounts and I can start setting up an account, but the GUI does 
nothing after I click "Apply", it doesn't add the account at all.

mc-tool add haze/steam-mobile tells me there's no such protocol steam-mobile in 
connection manager haze too. I wonder if there's something I'm missing.

Original comment by miguelpontes on 3 Nov 2012 at 3:15

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

To build on Ubuntu 13.04 x64 you must add libnss3-dev and change Makefile :

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 purple nss)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 purple nss)

Original comment by wizwi...@yahoo.fr on 15 Jun 2013 at 9:57

To build on Ubuntu 13.04 x64 you must add libnss3-dev and change Makefile :

CPPFLAGS += $(shell pkg-config --cflags glib-2.0 json-glib-1.0 purple nss)
LIBS += $(shell pkg-config --libs glib-2.0 json-glib-1.0 purple nss)

Original comment by wizwi...@yahoo.fr on 15 Jun 2013 at 9:57

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

Original comment by eionrobb on 15 Jun 2013 at 1:31

  • Changed state: Fixed

Original comment by eionrobb on 15 Jun 2013 at 1:31

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

- COMPILER is a non-standard variable name, a lot of scripts an package 
managers rely on CC

- your version ignores environment flags such as CFLAGS,CPPFLAGS and LDFLAGS, 
but hacks some standard flags in the compile line which is undesired behavior 
and needs patching downstream

- no install rule

- it's better to separate linking and compiling objects (for small projects it 
doesn't matter much, but I'd still do it)

- some scripts call "make clean" before "make" which would result in a failure 
since libsteam.so is not existent yet, that's why "-f" switch is commonly used 
there

- pkg-config should be put behind a variable... commonly used is PKG_CONFIG ?= 
pkg-config

Original comment by julian.o...@googlemail.com on 22 Jun 2013 at 11:22

- COMPILER is a non-standard variable name, a lot of scripts an package 
managers rely on CC

- your version ignores environment flags such as CFLAGS,CPPFLAGS and LDFLAGS, 
but hacks some standard flags in the compile line which is undesired behavior 
and needs patching downstream

- no install rule

- it's better to separate linking and compiling objects (for small projects it 
doesn't matter much, but I'd still do it)

- some scripts call "make clean" before "make" which would result in a failure 
since libsteam.so is not existent yet, that's why "-f" switch is commonly used 
there

- pkg-config should be put behind a variable... commonly used is PKG_CONFIG ?= 
pkg-config

Original comment by julian.o...@googlemail.com on 22 Jun 2013 at 11:22

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Aug 23, 2015

@julian.ospald  patches welcome :)

Original comment by eionrobb on 26 Jun 2013 at 4:36

@julian.ospald  patches welcome :)

Original comment by eionrobb on 26 Jun 2013 at 4:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment