Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walktrough: How I am using Github for my blog comments #6

Open
eiriksm opened this issue Apr 25, 2020 · 8 comments
Open

Walktrough: How I am using Github for my blog comments #6

eiriksm opened this issue Apr 25, 2020 · 8 comments

Comments

@eiriksm
Copy link
Owner

eiriksm commented Apr 25, 2020

https://eiriksm.dev/walkthrough-github-comments

@gitressa
Copy link

Awesome, thanks for taking the time to share how to set up hosting comments on Gitlab! It's always nice to have several options to choose between.

@dasjo
Copy link

dasjo commented May 24, 2020

Interesting approach

@ElijahLynn
Copy link

Gotta test this UX out... Thanks for the post!

@ElijahLynn
Copy link

After I left the above comment, a ctrl + R refresh on the page didn't show the comment but a ctrl + shift + r refresh (skip cache) did show it.

I think a solution needs to be worked out so that a normal refresh shows new comments.

@ElijahLynn
Copy link

But the comment above worked fine after clicking the link in the issue comment above. So 🤷.

@eiriksm
Copy link
Owner Author

eiriksm commented May 29, 2020

Thanks for the feedback! I do actually have automated tests for making sure it does not need a ctrl shift r refresh, so it could be caching on the server level too? Of course, the test could give a false positive too :) I will do some testing myself as well...

Thanks again for commenting! 🤓

@arafalov
Copy link

Interesting twist with live comments (I was waiting for the hook of some sort to trigger rebuild). But that means your home-page counts for the comments could be a bit out of sync with displayed counts on the page.

@eiriksm
Copy link
Owner Author

eiriksm commented Aug 12, 2020

Yes, very good point, that is true. The count will be a bit out of sync. The count was actually added after this article was written, so that is why it is not mentioned. But when a comment is posted on this repo, it triggers a rebuild of the blog, so it should be a matter of minutes 😄

Thanks for commenting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants