From b7a1a19edd5c5405c3127c85c7ecd907f326ffe0 Mon Sep 17 00:00:00 2001 From: Surya Sashank Nistala Date: Tue, 2 Jul 2024 11:41:50 -0700 Subject: [PATCH] fix stix ioc fetch failure scenario Signed-off-by: Surya Sashank Nistala --- .../securityanalytics/services/STIX2IOCFetchService.java | 1 + .../threatIntel/service/SATIFSourceConfigManagementService.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java b/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java index 867958a84..5c81feb8c 100644 --- a/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java +++ b/src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFetchService.java @@ -111,6 +111,7 @@ public void downloadAndIndexIOCs(SATIFSourceConfig saTifSourceConfig, ActionList } catch (Exception e) { log.error("Failed to download IOCs.", e); listener.onFailure(e); + return; } // TODO consider passing listener into the flush IOC function diff --git a/src/main/java/org/opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java b/src/main/java/org/opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java index fd164224d..acf137aa2 100644 --- a/src/main/java/org/opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java +++ b/src/main/java/org/opensearch/securityanalytics/threatIntel/service/SATIFSourceConfigManagementService.java @@ -167,7 +167,7 @@ public void createIocAndTIFSourceConfig( listener.onFailure(e); }, ex -> { log.error("Failed to delete threat intel source config [{}]", indexSaTifSourceConfigResponse.getId()); - listener.onFailure(ex); + listener.onFailure(e); } )); })