From dea20862dc886499b7644714e1db141195647ace Mon Sep 17 00:00:00 2001 From: arminha Date: Fri, 6 Dec 2019 16:24:45 +0100 Subject: [PATCH] DefaultArchiveExtractorTest shouldn't fail when symlinks cannot be created Files.createSymbolicLink can also fail with an IOException when the user doesn't have the rights to create a symlink. For example on Windows 10 as normal user withouth admin rights. --- .../plugins/frontend/lib/DefaultArchiveExtractorTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend-plugin-core/src/test/java/com/github/eirslett/maven/plugins/frontend/lib/DefaultArchiveExtractorTest.java b/frontend-plugin-core/src/test/java/com/github/eirslett/maven/plugins/frontend/lib/DefaultArchiveExtractorTest.java index c50d8e777..5c7ff3aae 100644 --- a/frontend-plugin-core/src/test/java/com/github/eirslett/maven/plugins/frontend/lib/DefaultArchiveExtractorTest.java +++ b/frontend-plugin-core/src/test/java/com/github/eirslett/maven/plugins/frontend/lib/DefaultArchiveExtractorTest.java @@ -57,10 +57,10 @@ public void extractBadTarFileSymlink() throws Exception { extractor.extract(BAD_TAR, link.toString()); } - private Path createSymlinkOrSkipTest(Path link, Path target) throws IOException { + private Path createSymlinkOrSkipTest(Path link, Path target) { try { return Files.createSymbolicLink(link, target); - } catch (UnsupportedOperationException e) { + } catch (UnsupportedOperationException | IOException e) { assumeTrue("symlinks not supported", false); return null; }