Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed filelists being generated #359

Open
maksis opened this issue Feb 21, 2017 · 6 comments
Open

Malformed filelists being generated #359

maksis opened this issue Feb 21, 2017 · 6 comments

Comments

@maksis
Copy link

maksis commented Feb 21, 2017

From http://adc.sourceforge.net/ADC.html#_file_names_and_structure :

each file or directory name must be unique in a case-insensitive context

Eiskalt seems to be ignoring the specs: cbc3ae5 (ShareManager section)

https://bugs.launchpad.net/dcplusplus/+bug/1665900

@felisucoibi
Copy link

yes this bugs affects lot of linux users that shares dc server with windows users aind airdc, it shoud ignore case sensitive duplicates o rename them in filelists.

@klondi
Copy link
Contributor

klondi commented Aug 20, 2021

[22:51:43] I guess it has to do with Linux having case sensitive folders unlike windows 
[22:52:03] Hard to fix on Linux because then the directories would conflate.

[22:52:32] i'd say that it has more to do with your client that isn't handling those correctly
[22:52:49] airdc won't generate such filelists
[22:52:52] dc++ neither
[22:53:41] Because it relies on case insensitive path names?
[22:54:50] yes, specifically to avoid such cases
[22:55:25] #359
[22:59:20] I can try to write a patch then. How would you handle the case of colliding filenames?
[22:59:34] combine the directories
[22:59:52] What if the collision happens for the files themselves?
[23:00:06] you might want to check out the code from dc++
[23:00:33] hmm, i think it adds numbers after the duplicates
[23:00:41] Do they handle that? I thought they went for the Windows assumption that they remain the same.
[23:02:44] I'll try to check that and write a patch then
[23:03:00] Thanks maksalaatikko !

@klondi
Copy link
Contributor

klondi commented Aug 20, 2021

So:

  1. Check how this is handled on DC++, removing folders is a bad idea so either merge or rename.
  2. Fix the code that generates the xml file.

@felisucoibi
Copy link

Maybe you should remove ips from the log, anyway thanks for keep alive this bug and try to fix it.

@klondi
Copy link
Contributor

klondi commented Aug 20, 2021

IPs? Which IPs? :P

@Tantrix
Copy link

Tantrix commented Oct 15, 2021

Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants