Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pango issue] Incorrect include path leads to hb.h: No such file or directory #413

Closed
ValdikSS opened this issue Aug 14, 2019 · 3 comments
Closed

Comments

@ValdikSS
Copy link
Contributor

EiskaltDC++ does not compile anymore with new pango on ArchLinux.
https://bugs.archlinux.org/task/63460
https://gitlab.gnome.org/GNOME/pango/issues/387
EiskaltDC++ should use cflags provided by pkg-config --cflags pango.

@JandeGrootDuracom
Copy link

The problem is in findGtk3.cmake which included hardcoded include paths:

If these ever change, things will break.

Pango requires harfbuzz since 1.44, so things will break.

@Vascom
Copy link
Contributor

Vascom commented Aug 14, 2019

We already have problems in Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1741077

@ValdikSS ValdikSS changed the title Incorrect include path leads to hb.h: No such file or directory [pango issue] Incorrect include path leads to hb.h: No such file or directory Aug 21, 2019
tehnick added a commit that referenced this issue Sep 22, 2019
@tehnick
Copy link
Member

tehnick commented Sep 22, 2019

As for builds with GTK+ 2.x you need to modify system file FindGTK2.cmake from cmake package. For example:

--- /usr/share/cmake-3.15/Modules/FindGTK2.cmake.orig
+++ /usr/share/cmake-3.15/Modules/FindGTK2.cmake
@@ -259,6 +259,7 @@
         gtkmm-2.4
         libglade-2.0
         libglademm-2.4
+        harfbuzz
         pango-1.0
         pangomm-1.4
         sigc++-2.0
@@ -707,6 +708,8 @@
         _GTK2_FIND_LIBRARY    (CAIRO cairo false false)
         _GTK2_ADD_TARGET      (CAIRO)
 
+        _GTK2_FIND_INCLUDE_DIR(HARFBUZZ hb.h)
+
         _GTK2_FIND_INCLUDE_DIR(PANGO pango/pango.h)
         _GTK2_FIND_LIBRARY    (PANGO pango false true)
         _GTK2_ADD_TARGET      (PANGO GTK2_DEPENDS gobject glib)

@tehnick tehnick closed this as completed Sep 22, 2019
cztomczak pushed a commit to cztomczak/cefpython that referenced this issue Feb 14, 2021
Fixes: #546

Had to include harfbuzz manually as newer Pango change this.
See:
    eiskaltdcpp/eiskaltdcpp#413
    https://gitlab.gnome.org/GNOME/pango/-/issues/387

Also had to add `-Wno-deprecated-declarations` to get this to compile because
of the following errors that didn't seem to be coming from this code directly:

    warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead
    warning: ‘GTypeDebugFlags’ is deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants