From fa67fdb9e85f9838ad7a35986f475ed20678e428 Mon Sep 17 00:00:00 2001 From: ascend-tech Date: Thu, 9 Oct 2025 10:51:27 -0400 Subject: [PATCH] Removed default detailtype. Causes error with LinkedTxn --- quickbooks/objects/deposit.py | 1 - tests/unit/objects/test_deposit.py | 20 ++++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/quickbooks/objects/deposit.py b/quickbooks/objects/deposit.py index a8b0c54f..b7b0299a 100644 --- a/quickbooks/objects/deposit.py +++ b/quickbooks/objects/deposit.py @@ -53,7 +53,6 @@ def __init__(self): self.LineNum = 0 self.Description = "" self.Amount = 0 - self.DetailType = "DepositLineDetail" self.LinkedTxn = [] self.CustomField = [] diff --git a/tests/unit/objects/test_deposit.py b/tests/unit/objects/test_deposit.py index 65d7a5bc..9d9b3ccb 100644 --- a/tests/unit/objects/test_deposit.py +++ b/tests/unit/objects/test_deposit.py @@ -2,6 +2,7 @@ from quickbooks import QuickBooks from quickbooks.objects.deposit import Deposit, DepositLine, CashBackInfo, DepositLineDetail +from quickbooks.objects.base import LinkedTxn class DepositTests(unittest.TestCase): @@ -26,6 +27,25 @@ def test_unicode(self): self.assertEqual(str(deposit), "100") + def test_init_no_detail_type(self): + deposit_line = DepositLine() + self.assertFalse(hasattr(deposit_line, 'DetailType')) + + def test_to_dict_with_linked_txn(self): + deposit_line = DepositLine() + deposit_line.Amount = 100 + + linked_txn = LinkedTxn() + linked_txn.TxnId = "123" + linked_txn.TxnType = "Payment" + linked_txn.TxnLineId = 0 + deposit_line.LinkedTxn.append(linked_txn) + + result = deposit_line.to_dict() + self.assertNotIn('DetailType', result) + self.assertEqual(result['Amount'], 100) + self.assertEqual(len(result['LinkedTxn']), 1) + class CashBackInfoTests(unittest.TestCase): def test_init(self):