New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertfile command creates a "files" directory, but doesn't include it in commit. #49

Closed
dmitshur opened this Issue Sep 11, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@dmitshur
Contributor

dmitshur commented Sep 11, 2018

Reproduce steps:

  1. cd into ~/.passgo and git status, note that it's clean

  2. use passgo insertsite ...

  3. do git status, see:

    On branch master
    Untracked files:
      (use "git add <file>..." to include in what will be committed)
    
    	files/
    
    nothing added to commit but untracked files present (use "git add" to track)
    

I suspect it's because git add -u is used to stage files in sync.Commit:

_, err = exec.Command("git", "add", "-u").Output()

Perhaps git add -A would be more appropriate?

@ejcx

This comment has been minimized.

Show comment
Hide comment
@ejcx

ejcx Sep 20, 2018

Owner

Good catch! Thanks for the report.

Owner

ejcx commented Sep 20, 2018

Good catch! Thanks for the report.

ejcx added a commit that referenced this issue Sep 20, 2018

Issue #49. Fix file directory not being committed.
Thanks dmitshur, we need to be sure that we add the directory
and all updated files, not just updated files.

@ejcx ejcx closed this Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment