Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start building in module mode #62

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@dmitshur
Copy link
Contributor

commented Jun 20, 2019

Start building passgo in module mode, which is available in Go 1.11
and newer.

Add go.mod and go.sum files. Since there's already a v2.0.0 tag, start
at v2 instead of v1. This is primarily a command, not a library, so
it's viable not to immediately increase major version by one despite
the pre-go.mod v2.0.0 tag. However, a new v2.1.0 release tag will need
to be created after this change is merged, so that the latest version
includes this change.

Given we're now building in module mode, start using debug.ReadBuildInfo
to determine the version, instead of hardcoding it into the source code.

Remove vendor directory for now; it's no longer necessary and can be
re-added if/when there's a concrete need for it.

Fixes #61

/cc @FiloSottile FYI.

start building in module mode
Start building passgo in module mode, which is available in Go 1.11
and newer.

Add go.mod and go.sum files. Since there's already a v2.0.0 tag, start
at v2 instead of v1. This is primarily a command, not a library, so
it's viable not to immediately increase major version by one despite
the pre-go.mod v2.0.0 tag. However, a new v2.1.0 release tag will need
to be created after this change is merged, so that the latest version
includes this change.

Given we're now building in module mode, start using debug.ReadBuildInfo
to determine the version, instead of hardcoding it into the source code.

Remove vendor directory for now; it's no longer necessary and can be
re-added if/when there's a concrete need for it.

Fixes #61

@dmitshur dmitshur force-pushed the dmitshur:module-mode branch from e42640e to d2f4c13 Jun 20, 2019

@ejcx

This comment has been minimized.

Copy link
Owner

commented Jun 20, 2019

Ill give these a test in the next couple days, and if I merge I will cut a new release and update docs if they need to be updated.

Thanks a lot for making this change.

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Friendly ping. 🙂

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Friendly ping. Please let me know if I can help in making this PR easier to review.

@ejcx

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

@ejcx ejcx merged commit c32b027 into ejcx:master Sep 9, 2019

@ejcx

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

Just gave it a try. I had taken a look a few months ago but honestly didn't have a recent enough version of go to test go modules, then I got distracted. All looks good now. Thanks for the PR and I apologize for the delay!

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

No worries and thank you!

@dmitshur dmitshur deleted the dmitshur:module-mode branch Sep 9, 2019

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@ejcx As a heads up, you'll need to make a newer v2.x.y tag that includes this change, otherwise the current installation command in the README will not pick it up.

@ejcx

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2019

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.