updates to chameleon #2

Merged
merged 3 commits into from Apr 16, 2011

Conversation

Projects
None yet
2 participants
@lenidot
Contributor

lenidot commented Apr 5, 2011

Hi Elliot - this is my first pull request so apologies if I've stuffed it up.

Changes:

  • added support for funnel widget
  • railtie_name was generating warnings on rails server start
  • Rails::Application seems to be deprecated in Rails 3

Cheers -

Leni

@ejdraper ejdraper merged commit 64647de into ejdraper:master Apr 16, 2011

@ejdraper

This comment has been minimized.

Show comment
Hide comment
@ejdraper

ejdraper Apr 16, 2011

Owner

Hi Leni,

Thanks for this, that's great! I've merged these changes in, and just made a few slight tweaks (f157dab). I added a test for the funnel widget, and also changed it so that to hide the percentage you have to pass in :hide_percentage (and not just :percentage). Lastly, I just made the items array an array of hashes explicitly specifying a value, and a label, to be consistent with other widgets. If you have widgets using your code already they should be fairly easy to update to work with v0.2.2 of Chameleon and the changes I made.

Thanks for your contribution!

Elliott

Owner

ejdraper commented Apr 16, 2011

Hi Leni,

Thanks for this, that's great! I've merged these changes in, and just made a few slight tweaks (f157dab). I added a test for the funnel widget, and also changed it so that to hide the percentage you have to pass in :hide_percentage (and not just :percentage). Lastly, I just made the items array an array of hashes explicitly specifying a value, and a label, to be consistent with other widgets. If you have widgets using your code already they should be fairly easy to update to work with v0.2.2 of Chameleon and the changes I made.

Thanks for your contribution!

Elliott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment