We want the best offer not the worst offer!

ejholmes · Apr 28, 2012 · c356add · c356add
1 parent a2da949
commit c356add
Show file tree

Hide file tree

Showing 3 changed files with 117 additions and 2 deletions.
diff --git a/lib/octopart/part.rb b/lib/octopart/part.rb
@@ -129,7 +129,7 @@ def best_offer(quantity = 1)
         p = offer.prices.select { |p| p[0] <= quantity }.last
         prices << { sku: offer.sku, price: p[1] } if p
       end
-      best = prices.max_by { |p| p[:price] }
+      best = prices.min_by { |p| p[:price] }
       offers.find { |offer| offer.sku == best[:sku] }
     end
 

diff --git a/spec/fixtures/cassettes/Octopart_Part/_best_offer/for_a_quantity_of_100.yml b/spec/fixtures/cassettes/Octopart_Part/_best_offer/for_a_quantity_of_100.yml
diff --git a/spec/lib/part_spec.rb b/spec/lib/part_spec.rb
@@ -96,7 +96,14 @@
       use_vcr_cassette
       subject { described_class.find(39619421).best_offer.sku }
 
-      it { should eq('1693062') }
+      it { should eq('H466A') }
+    end
+
+    context "for a quantity of 100" do
+      use_vcr_cassette
+      subject { described_class.find(39619421).best_offer.sku }
+
+      it { should eq('H466A') }
     end
   end
 end