Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce property based tests for more rigor, plus some examples of failing combinations #1
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm surprised to see there are some failing cases. Thanks for setting this up! I'll keep prop testing in for u32 and u64, but the space is small enough for u16 and especially for u8 that we might as well have an exhaustive test. |
ejmahler
merged commit e6bd607
into
ejmahler:master
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZackPierce commentedJan 4, 2019
•
edited
This PR is intended to broaden the tested input for this library through the use of property based testing.
So far these test runs have exposed some failing input combinations, a few of which I've included as short term spot-unit-tests for regression comparison.
There's a bit more code replication than I would prefer in the correctness assertion logic, but I haven't had time to introduce sufficient macro or private-trait effort to DRY things up fully. Hopefully it's tolerable for the time being as correctness is improved.