The virtual environment's path is no longer hardcoded into the activation script. #13

Merged
merged 1 commit into from Mar 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

mrinalwadhwa commented Mar 7, 2012

The hardcoded path of the environment in the generated activation script broke the activation script if the directory containing the environment was moved, this change fixes that.

ekalinin added a commit that referenced this pull request Mar 8, 2012

Merge pull request #13 from mrinalwadhwa/master
The virtual environment's path is no longer hardcoded into the activation script.

@ekalinin ekalinin merged commit 2e1aae5 into ekalinin:master Mar 8, 2012

Owner

ekalinin commented Mar 8, 2012

Hi @mrinalwadhwa,

Excellent patch. Applied.
Thanks.

Contributor

mrinalwadhwa commented Mar 11, 2012

Hi Eugene,

From your last commit, it looks like you ran into the issue with /bin/sh pointing to dash is ubuntu as well.

I noticed it yesterday, my attempt at fixing it was to force python to invoke bash when it runs a command in a shell, this way BASH_SOURCE is always available.
mrinalwadhwa/nodeenv@ce0ea45

What do you think?

This fixes the nodeenv python program as long as /bin/bash is available ... the activation script however, when triggered manually, must always be invoked in bash.

Thank you
Mrinal

Owner

ekalinin commented Mar 13, 2012

Hi Mrinal,

From your last commit, it looks like you ran into the issue with /bin/sh pointing to dash is ubuntu as well.

Yep.

I noticed it yesterday, my attempt at fixing it was to force python to invoke bash when it runs a command in a shell, this way BASH_SOURCE is always available.
mrinalwadhwa/nodeenv@ce0ea45

What do you think?

At first my solution was the same as your.
But later I have decided that it would be better not to limit nodeenv's users with certain shells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment