CLI interface for typogr.js #6

Merged
merged 2 commits into from Jul 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

mnewt commented Mar 20, 2013

I wrote a cli interface for typogr.js. I thought you might want to incorporate it into your repo in some way.

Please have a look and let me know what you think.

I'm happy to keep it separate--I just thought I'd extend the option of pulling it in if you like.

Cheers,
MN

@ekalinin ekalinin added a commit that referenced this pull request Jul 1, 2013

@ekalinin ekalinin Merge pull request #6 from mnewt/cli
CLI interface for typogr.js
fbc9779

@ekalinin ekalinin merged commit fbc9779 into ekalinin:master Jul 1, 2013

Owner

ekalinin commented Jul 1, 2013

Sorry for delay. Great patch! Thanks!

Owner

ekalinin commented Jul 1, 2013

Hmmm:

➥ ./node_modules/.bin/mocha test/test.cli.js

  ․․․․․․․․․․․

  2 passing (133 ms)
  9 failing

The most common error:

Uncaught Error: Command failed: /bin/sh: 1: ./bin/typogr: not found

it seems that this changeset is not complete?

Owner

ekalinin commented Jul 2, 2013

Ok, Added ./bin/typogr by hands.

Contributor

mnewt commented Jul 2, 2013

I swear it passed when I submitted it :) I just ran the test suite on my machine and I get:

% ./node_modules/.bin/mocha test/test.cli.js

․․․․․․․․․․․․

✖ 3 of 11 tests failed

I'm super busy at the moment. I'll look into it soon and fix it

Owner

ekalinin commented Jul 3, 2013

I'm super busy at the moment. I'll look into it soon and fix it

It's ok. I've already fixed them:

Contributor

mnewt commented Jul 6, 2013

Great edits. Thanks for merging and fixing!

On Wednesday, July 3, 2013 at 2:02 AM, Eugene Kalinin wrote:

The content of the message has not been downloaded yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment