Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decypt): add EncryptionException to detect openssl_encrypt and openssl_decrypt failures #18

Merged
merged 1 commit into from Sep 3, 2019
Merged

feat(decypt): add EncryptionException to detect openssl_encrypt and openssl_decrypt failures #18

merged 1 commit into from Sep 3, 2019

Conversation

wjehanne
Copy link
Contributor

No description provided.

mremi
mremi reviewed Aug 28, 2019
View reviewed changes
DependencyInjection/EnvVarEncryptedProcessor.php Outdated Show resolved Hide resolved
Encryptor/Encryptor.php Outdated Show resolved Hide resolved
Exception/OpenSSLException.php Outdated Show resolved Hide resolved
Encryptor/Encryptor.php Show resolved Hide resolved
@wjehanne wjehanne changed the title WIP: feat(decypt): add OpenSSLException to detect open_decrypt failure feat(decypt): add OpenSSLException to detect open_decrypt failure Aug 29, 2019
mremi
mremi reviewed Aug 29, 2019
View reviewed changes
Tests/Encryptor/EncryptorTest.php Outdated Show resolved Hide resolved
Tests/Encryptor/EncryptorTest.php Outdated Show resolved Hide resolved
Tests/Encryptor/EncryptorTest.php Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 29, 2019 •
edited

Coverage Status

Coverage increased (+16.3%) to 83.333% when pulling 1f1f06f on williamjehanne:master into e5cd05c on ekino:master.

@wjehanne wjehanne changed the title feat(decypt): add OpenSSLException to detect open_decrypt failure feat(decypt): add EncryptionException to detect openssl_encrypt and openssl_decrypt failures Aug 29, 2019
mazsudo
mazsudo suggested changes Aug 29, 2019
View reviewed changes
Tests/Encryptor/EncryptorTest.php Outdated Show resolved Hide resolved
mremi
mremi reviewed Sep 2, 2019
View reviewed changes
Tests/Controller/LogsAdminControllerTest.php Outdated Show resolved Hide resolved
Tests/Encryptor/EncryptorTest.php Outdated Show resolved Hide resolved
@mazsudo mazsudo merged commit 6867423 into ekino:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mremi mremi mremi approved these changes

@mazsudo mazsudo mazsudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wjehanne @coveralls @mremi @mazsudo