Fix multiple problems in Erf and InvErf methods #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes errors in
normcdf
,inverf
,inverfc
andinvnormcdf
.normcdf
By definition,
normcdf = (/2) . erfc . negate . (/sqrt 2)
. However,inverf
etc.inverf . erf
anderf . inverf
should be both identity functions (within their domain), so their derivative should beconst 1
. However,There are similar issues with
inverfc
andinvnormcdf
.