Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

We could use some benchmarks for the `Control.Lens.Zipper`. #121

Closed
ekmett opened this Issue · 4 comments

5 participants

@ekmett
Owner

@shachaf was looking into Control.Lens.Zipper core improvements, but before it gets too quantitative we need benchmarks.

@shachaf shachaf was assigned
@jwiegley jwiegley was assigned
@ekmett
Owner
[03:37] shachaf:     And I've already made some of my improvements, so maybe I'll wash my hands of the whole thing.
[03:37] edwardk:     i think your reverse hack at least solved the worst issues with zipper
[03:37] edwardk:     so moving down into a lens is at least less horrible
[03:38] edwardk:     (well, i suppose, coming back up)
...
[03:38] shachaf:     Yes, if you never move right or left it's good.
[03:38] shachaf:     Also, if you move right N and then move left N.
[03:39] shachaf:     Right now GHC doesn't figure out rezip statically, though.
[03:39] shachaf:     (So tug left & rezip might be better than rezip.)
[03:39] shachaf:     (Anyway I'm tired of making speculations like that.)
@thoughtpolice
Collaborator

I have a few benchmarks of rezip at the very least. @shachaf is correct that farthest leftward & rezip is over twice is as fast as just doing rezip (and leftmost & rezip is faster than both.)

I'll add some more stuff I can think of and open a pull request.

@ekmett
Owner

Sounds great. =) Thanks, Austin!

@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@thoughtpolice thoughtpolice referenced this issue from a commit
@thoughtpolice thoughtpolice Some very basic zipper benchmarks.
Issue #121.

Signed-off-by: Austin Seipp <mad.one@gmail.com>
2ef9dad
@thoughtpolice thoughtpolice referenced this issue from a commit
@thoughtpolice thoughtpolice Add benchmarks for zipper creation and a basic traversal.
Issue #121.

Signed-off-by: Austin Seipp <mad.one@gmail.com>
6a10bdf
@thoughtpolice thoughtpolice referenced this issue from a commit
@thoughtpolice thoughtpolice Add tugTo to rezipping benchmark. Issue #121.
Signed-off-by: Austin Seipp <mad.one@gmail.com>
30dbd49
@thoughtpolice thoughtpolice was assigned
@glguy
Collaborator

Zipper was extracted from lens

@glguy glguy closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.