Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

We could use some benchmarks for the `Control.Lens.Zipper`. #121

Closed
ekmett opened this Issue Nov 24, 2012 · 4 comments

Comments

Projects
None yet
5 participants
Owner

ekmett commented Nov 24, 2012

@shachaf was looking into Control.Lens.Zipper core improvements, but before it gets too quantitative we need benchmarks.

@ghost ghost assigned shachaf Nov 26, 2012

@ghost ghost assigned jwiegley Dec 14, 2012

Owner

ekmett commented Dec 14, 2012

[03:37] shachaf:     And I've already made some of my improvements, so maybe I'll wash my hands of the whole thing.
[03:37] edwardk:     i think your reverse hack at least solved the worst issues with zipper
[03:37] edwardk:     so moving down into a lens is at least less horrible
[03:38] edwardk:     (well, i suppose, coming back up)
...
[03:38] shachaf:     Yes, if you never move right or left it's good.
[03:38] shachaf:     Also, if you move right N and then move left N.
[03:39] shachaf:     Right now GHC doesn't figure out rezip statically, though.
[03:39] shachaf:     (So tug left & rezip might be better than rezip.)
[03:39] shachaf:     (Anyway I'm tired of making speculations like that.)
Collaborator

thoughtpolice commented Jan 4, 2013

I have a few benchmarks of rezip at the very least. @shachaf is correct that farthest leftward & rezip is over twice is as fast as just doing rezip (and leftmost & rezip is faster than both.)

I'll add some more stuff I can think of and open a pull request.

Owner

ekmett commented Jan 4, 2013

Sounds great. =) Thanks, Austin!

thoughtpolice added a commit that referenced this issue Jan 5, 2013

Some very basic zipper benchmarks.
Issue #121.

Signed-off-by: Austin Seipp <mad.one@gmail.com>

thoughtpolice added a commit that referenced this issue Jan 5, 2013

Add benchmarks for zipper creation and a basic traversal.
Issue #121.

Signed-off-by: Austin Seipp <mad.one@gmail.com>

thoughtpolice added a commit that referenced this issue Jan 5, 2013

Add tugTo to rezipping benchmark. Issue #121.
Signed-off-by: Austin Seipp <mad.one@gmail.com>

@ghost ghost assigned thoughtpolice Jan 5, 2013

Collaborator

glguy commented May 14, 2013

Zipper was extracted from lens

@glguy glguy closed this May 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment